-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tags using handlebars, update styles #37
Conversation
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
src/helpers/split.js
Outdated
@@ -0,0 +1,10 @@ | |||
'use strict' | |||
|
|||
module.exports = (val) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice helper function! I think one improvement could be the ability to pass the split character/string as the second argument in case we want to split on something else.
Something like (val, char) => {
and then val.split(char)
src/partials/toc.hbs
Outdated
<h3>Tags</h3> | ||
<div> | ||
{{#each (split page.attributes.tags) }} | ||
<span>{{this}}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be useful to have a class on these spans, <span class="span">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops I typoed, I meant class="tag"
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for making those changes
Content Rail
Tags
Tags are now using handlebars with the following page attribute
page-tags: Astra, ML, SDK, ...
Tags are rendered as span elements at this time and can be changed to anchor elements in the future.
Styling
Update headers, text styles and colors with figma