Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse nav sections #41

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Collapse nav sections #41

merged 7 commits into from
Nov 6, 2023

Conversation

colegoldsmith
Copy link
Collaborator

No description provided.

@mlr
Copy link
Contributor

mlr commented Oct 31, 2023 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Oct 31, 2023 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Nov 1, 2023 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Nov 1, 2023 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Nov 1, 2023 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Nov 1, 2023 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Nov 1, 2023 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Nov 1, 2023

Antora site build successful! ✅
Deploying draft to GitHub Pages.

@mlr
Copy link
Contributor

mlr commented Nov 3, 2023 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@eric-schneider
Copy link
Contributor

@colegoldsmith I approve of the collapse behavior. Nice work! I did notice that the resources at the bottom of the nav still aren't fixed in place. Is that already getting fixed in another PR?

@mlr
Copy link
Contributor

mlr commented Nov 6, 2023 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@colegoldsmith
Copy link
Collaborator Author

@eric-schneider I fixed the bottom nav items, they are position: sticky now so they stay floating at the bottom

@mlr
Copy link
Contributor

mlr commented Nov 6, 2023 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@colegoldsmith colegoldsmith merged commit c9d488c into main Nov 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlr mlr Awaiting requested review from mlr

@josuebran josuebran Awaiting requested review from josuebran

@eric-schneider eric-schneider Awaiting requested review from eric-schneider

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colegoldsmith @mlr @eric-schneider