Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site layout refactor #61

Merged
merged 22 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .stylelintrc

This file was deleted.

10 changes: 0 additions & 10 deletions gulp.d/tasks/lint-css.js

This file was deleted.

8 changes: 1 addition & 7 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ const cleanTask = createTask({
call: task.remove(['build', 'public']),
})

const lintCssTask = createTask({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to remove stylelint for the project. It's no longer maintained and was causing some headaches with prettier. And now that we have prettier I feel that is a good replacement, though it would be ideal to add a step in the gulp process to run prettier on our css files to keep things consistent much like stylelint was doing. Let's handle that later

name: 'lint:css',
desc: 'Lint the CSS source files using stylelint (standard config)',
call: task.lintCss(glob.css),
})

const lintJsTask = createTask({
name: 'lint:js',
desc: 'Lint the JavaScript source files using eslint (JavaScript Standard Style)',
Expand All @@ -42,7 +36,7 @@ const lintJsTask = createTask({
const lintTask = createTask({
name: 'lint',
desc: 'Lint the CSS and JavaScript source files',
call: parallel(lintCssTask, lintJsTask),
call: lintJsTask,
})

const formatTask = createTask({
Expand Down
Loading
Loading