Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prover api #106

Merged
merged 28 commits into from
May 31, 2024
Merged

Refactor prover api #106

merged 28 commits into from
May 31, 2024

Conversation

capossele
Copy link
Contributor

@capossele capossele commented May 16, 2024

Closes #92

@capossele capossele self-assigned this May 16, 2024
@capossele capossele marked this pull request as draft May 16, 2024 13:32
@nategraf
Copy link
Contributor

In order to test this against risc0 main, I did some work to update a few things #109

.github/actions/cargo-risczero-install/action.yaml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
@nategraf
Copy link
Contributor

Note: I also force-pushed the dev branch to match the commit history of main. I think ideally, we'll have main lag behind dev, but share git history with it.

* remove dependency on murky

* update forge std and openzeppelin versions

* point risc0-ethereum submodule to release-1.0 branch

* switch cargo refs to main

* fix up build issues

* update notes in the README about proving with Groth16

* point to the pending release-1.0 branch

* move TxSender directly into publisher

* remove unused submodule
@nategraf
Copy link
Contributor

@capossele, I pushed a few commits to this branch. Definitely let me know if you disagree with any of the changes.

@nategraf
Copy link
Contributor

In the latest commits, I am using the cargo-risczero-install action from risc0/risc0-ethereum#128

@nategraf nategraf marked this pull request as ready for review May 31, 2024 18:09
@nategraf nategraf merged commit 39b01a4 into dev May 31, 2024
3 checks passed
@nategraf nategraf deleted the capossele/refactor-prover-api branch May 31, 2024 18:10
nategraf added a commit that referenced this pull request Jun 4, 2024
* update zkvm usage

* update lib

* update risc0-ethereum

* improve local prover instructions

* update deps

* bump risc0-ethereum

* bump risc0-ethereum

* bump risc0-ethereum

* add deployment guide

* bump risc0-ethereum

* use local prover

* fix action

* use main branch

* use sccache

* add permissions

* use ubuntu

* Set submodule commits to match dependencies on risc0-ethereum (#109)

* remove dependency on murky

* update forge std and openzeppelin versions

* point risc0-ethereum submodule to release-1.0 branch

* switch cargo refs to main

* fix up build issues

* update notes in the README about proving with Groth16

* point to the pending release-1.0 branch

* move TxSender directly into publisher

* remove unused submodule

* use cargo-risczero-install action from risc0-ethereum and remove unused deps

* fix use of removed env var

* i see you, whitespace

* use pending version of cargo-risczero-install

* bump CI

* bump

* bump cargo-risczero-install action

* update risc0-ethereum refs to the v1.0.0-rc.6 tag

---------

Co-authored-by: Victor Graf <[email protected]>
nategraf added a commit that referenced this pull request Jun 6, 2024
* update zkvm usage

* update lib

* update risc0-ethereum

* improve local prover instructions

* update deps

* bump risc0-ethereum

* bump risc0-ethereum

* bump risc0-ethereum

* add deployment guide

* bump risc0-ethereum

* use local prover

* fix action

* use main branch

* use sccache

* add permissions

* use ubuntu

* Set submodule commits to match dependencies on risc0-ethereum (#109)

* remove dependency on murky

* update forge std and openzeppelin versions

* point risc0-ethereum submodule to release-1.0 branch

* switch cargo refs to main

* fix up build issues

* update notes in the README about proving with Groth16

* point to the pending release-1.0 branch

* move TxSender directly into publisher

* remove unused submodule

* use cargo-risczero-install action from risc0-ethereum and remove unused deps

* fix use of removed env var

* i see you, whitespace

* use pending version of cargo-risczero-install

* bump CI

* bump

* bump cargo-risczero-install action

* update risc0-ethereum refs to the v1.0.0-rc.6 tag

---------

Co-authored-by: Victor Graf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants