Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qualcomm feedback] Chapter 5.3 Clarify recommendations for re-entrant TSM #58

Closed
rsahita opened this issue Feb 6, 2024 · 2 comments
Closed

Comments

@rsahita
Copy link
Collaborator

rsahita commented Feb 6, 2024

Reference: link

The TSM is stateless across TEECALL invocations, however a security routine invoked in the TSM
via a TEECALL may be interrupted and must be resumed via a TEERESUME i.e. the TSM is
preemptable but non-reentrant.

How can it be stateless if it's holding TVM memory mapping information?

this is not really an explanation for the previous sentence. An interrupted TEECALL needs to be resumed by a TEERESUME even when the TSM is reentrant. Overall this explanation is just confusing.

@rsahita
Copy link
Collaborator Author

rsahita commented Mar 9, 2024

this should say
The TSM-driver is stateless...

@rsahita
Copy link
Collaborator Author

rsahita commented Mar 10, 2024

Closing as addressed in PR #70
cc @ozkoyuncu

@rsahita rsahita closed this as completed Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant