Fix for test program compilation failures due to lack of zicsr extension in -march=rvXX...
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the pylint failure is not your fault, and will be fixed by #483. |
timsifive
requested changes
Jun 30, 2023
There was a problem hiding this comment.
Can you give the PR a title that someone can read without knowing github issue numbers by heart?
Change looks fine, but I'm a bit concerned about it not working with older GCC versions. Specifically, OpenOCD automatically runs these tests using https://github.com/riscv/riscv-openocd/blob/riscv/.github/workflows/spike-openocd-tests.yml.
Can you confirm that these new flags are supported by the toolchain referred to on line 10 of that file?
|
Thanks @timsifive .
Sorry - I thought that it was sufficient to link to the issue.
I'm pretty sure that any post GCC 12 toolchain will support |
TommyMurphyTM1234
changed the title
zicsr extension in -march=rvXX...
Hi @timsifive - I can confirm that those tests using the xPack toolchain in question still work fine with this PR's change. |
timsifive
approved these changes
Jul 5, 2023
|
Thanks for merging @timsifive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for:
zicsrextension in-march=...#482Note that this fix means that the tests will probably fail to compile with a pre GCC 12 RISC-V toolchain which predates the separation of the
zicsr(andzifencei) extension(s) out from the base integer ISA. But I didn't think that it was worthwhile complicating the script further by trying to cater for older toolchains in the script.