debug: Test OpenOCD behavior when harts become unavailable, using new spike mechanism #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregSavin
approved these changes
Jul 7, 2023
|
These tests sometimes fail (depending on which hart is randomly selected) in the multi-spike scenario. Instead of fixing that, I'm changing it so they don't run there. The fix is somewhat complex, the test takes forever to run (15+ minutes), and the additional coverage is negligible. |
Just so it's easier to quickly comment out code and hard-code the target to use without pylint complaining. This really should be a command line option.
It's a bit messy to read the log file to get the output, but it seems to be flushed often so that this works. Also, added the `targets` method for retrieving the list of targets, and `wait_until_running` method to wait until all targets are in a running state.
Use the new spike mechanism to test OpenOCD behavior when a hart becomes unavailable while running. Create CommandException.
Use new spike mechanism to test OpenOCD behavior when the current hart becomes unavailable while running. Create ThreadTerminated exception.
Use new spike mechanism to test OpenOCD behavior when a hart becomes unavailable, and then available again.
|
Fixed a but that happened when running commands through the OpenOCD CLI when |
GregSavin
approved these changes
Jul 17, 2023
timsifive
added a commit
to riscv-collab/riscv-openocd
that referenced
this pull request
Jul 18, 2023
riscv-software-src/riscv-tests#489 doesn't play nice with github workflow somehow. Change-Id: I6efa612a085cee3b64a5e4e58408de202069c045 Signed-off-by: Tim Newsome <[email protected]>
timsifive
added a commit
to riscv-collab/riscv-openocd
that referenced
this pull request
Jul 18, 2023
riscv-software-src/riscv-tests#489 doesn't play nice with github workflow somehow. Change-Id: I6efa612a085cee3b64a5e4e58408de202069c045 Signed-off-by: Tim Newsome <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests won't pass until riscv-collab/riscv-openocd#879 merges.