Disable timer interrupt to fix some bugs #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsifive
requested changes
Sep 28, 2023
debug/gdbserver.py
Outdated
Comment on lines
1042
to
1047
| # Disable timer interrupt | ||
| for hart in self.target.harts: | ||
| self.gdb.select_hart(hart) | ||
| self.gdb.p("$mie") | ||
| self.gdb.p("$mie=$mie & ~0x80") | ||
| self.gdb.p("$mie") |
There was a problem hiding this comment.
Can you make this a helper function in GdbTest, and call that from the various places that need it?
You can probably remove the extra prints of $mie, too.
There was a problem hiding this comment.
I have made the changes as you suggested and conducted debug testing.
timsifive
reviewed
Oct 9, 2023
debug/gdbserver.py
Outdated
Comment on lines
1196
to
1200
| # Disable timer interrupt | ||
| for hart in self.target.harts: | ||
| self.gdb.select_hart(hart) | ||
| self.gdb.interrupt() | ||
| self.gdb.p("$mie=$mie & ~0x80") |
There was a problem hiding this comment.
For more refactoring, can you make this a call to disable_timer() as well?
Probably you need a new interrupt=False argument to disable_timer(), and if it's True then it does the interrupt().
There was a problem hiding this comment.
Your suggestions are very helpful and I have adopted it.
Signed-off-by: liangzhen <[email protected]>
timsifive
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off the timer interrupt after the test case (such as InterruptTest) ends to avoid interference with other test cases.