Support limits_icount_to_one in IcountTest #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The UnavailableHaltedTest returned exception, I also tried |
|
My modifications don't seem to affect UnavailableTest, but UnavailableHaltedTest returns an exception in spike64-2 tests. I tried git reset --hard 3366371 and ran the spike test locally, it returned an exception. However, I tried git revert 3366371 and ran the spike test locally, it returned no exception. However, In commit 3366371, the spike tests in github workflow return success, I can't figure it out. |
timsifive
requested changes
Oct 23, 2023
debug/targets.py
Outdated
Comment on lines
141
to
143
| # When true it indicates that the hardware limits icount set to 1 | ||
| limits_icount_to_one = False | ||
|
|
There was a problem hiding this comment.
Instead of limits_icount_to_one = False how about icount_limit = 4 (or whatever default seems reasonable)?
There was a problem hiding this comment.
I have changed it according to your opinion.
This is taking into account that the hardware limits count to 1. Signed-off-by: liangzhen <[email protected]>
timsifive
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#516 This is taking into account that the hardware limits count to 1.