Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI for OpenOCD/debugger tests #542

Closed

Conversation

aap-sc
Copy link
Collaborator

@aap-sc aap-sc commented Mar 1, 2024

git ls-remote lists both refs/head and refs/remotes. riscv-openocd got
a new entry in refs/remotes that matches riscv pattern around Jan 25.
This breaks gitlab pipeline. The commit restricts ls-remote only to
refs/head.

In addition this commit changes the address of riscv-openocd repository,
since it was moved to riscv-collab space a while ago.

@aap-sc aap-sc force-pushed the aap-sc/fix_debug_tests_ci branch from f92a190 to 449a57f Compare March 1, 2024 04:56
@aap-sc
Copy link
Collaborator Author

aap-sc commented Mar 1, 2024

This PR should fix the issue: #543

@aap-sc
Copy link
Collaborator Author

aap-sc commented Mar 1, 2024

@lz-bro , @aswaterman FYI.

@en-sc could you please review this one?

`git ls-remote` lists both `refs/head` and `refs/remotes`. riscv-openocd got
a new entry in refs/remotes that matches `riscv` pattern around Jan 25.
This breaks gitlab pipeline. The commit restricts ls-remote only to
`refs/head`.

In addition this commit changes the address of riscv-openocd repository,
since it was moved to riscv-collab space a while ago.
@aap-sc aap-sc force-pushed the aap-sc/fix_debug_tests_ci branch from 449a57f to 4a0aa08 Compare March 1, 2024 05:33
@en-sc
Copy link
Collaborator

en-sc commented Mar 1, 2024

Seems like the other match, which cased trouble (refs/remotes/riscv-openocd/riscv) was added to riscv-openocd by mistake. I have deleted it and the pipelines should work without the patch from now on (re-run example).

However, the link to riscv-openocd repo should still be updated.

As for the part regarding revisions, I do think we can use a more robust mechanism here.
I see the following alternatives:

  • Change OPENOCD_REV to HEAD -- this will protect against changing the default branch in riscv-openocd
  • Change OPENOCD_REV to refs/tags/latest -- this is the tag, updated by snapshot.yml workflow on push. IMHO, this is the best option, since this tag is the closest thing to a release in riscv-openocd.
  • Leave it as-is, since if it works -- don't touch it :)

@aap-sc
Copy link
Collaborator Author

aap-sc commented Mar 1, 2024

I have deleted it and the pipelines should work without the patch from now on ([re-run example]

Yep. It works now. I'll abandon the patch then

@aap-sc aap-sc closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants