Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug tests] increase remotetimeout for all spike-based targets #553

Conversation

aap-sc
Copy link
Collaborator

@aap-sc aap-sc commented May 1, 2024

Spike simulator is very demanding to CPU resources. This causes debug tests to sporadically fail on slower machines. Increasing of gdb's remotetimeout should get rid of such failures, unless we run the testsuite on a potato.

The only downside is that if OpenOCD is broken, tests can run longer. However, I think this is the sacrifice we can make, since execution time is not affected if everything works as expected.

Spike simulator is very demanding to CPU resources. This causes debug
tests to sporadically fail on slower machines. Increasing of gdb's
`remotetimeout` should get rid of such failures, unless we run the
testsuite on a potato.

The only downside is that if OpenOCD is broken, tests can run longer.
However, I think this is the sacrifice we can make, since execution time
is not affected if everything works as expected.
@aap-sc aap-sc requested a review from en-sc May 1, 2024 09:13
@aap-sc
Copy link
Collaborator Author

aap-sc commented May 1, 2024

@en-sc , please, take a look.

@TommyMurphyTM1234 FYI

@TommyMurphyTM1234
Copy link
Contributor

Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@aswaterman aswaterman merged commit 1dde0ef into riscv-software-src:master May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants