Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug/test binary file #574

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Remove debug/test binary file #574

merged 1 commit into from
Aug 7, 2024

Conversation

en-sc
Copy link
Collaborator

@en-sc en-sc commented Aug 7, 2024

The file was added by 00ab5f0 in #567. Seems like a mistake.

> readelf -h debug/test
ELF Header:
  Magic:   7f 45 4c 46 02 01 01 00 00 00 00 00 00 00 00 00
  Class:                             ELF64
  Data:                              2's complement, little endian
  Version:                           1 (current)
  OS/ABI:                            UNIX - System V
  ABI Version:                       0
  Type:                              EXEC (Executable file)
  Machine:                           RISC-V
  Version:                           0x1
  Entry point address:               0x1212340000
  Start of program headers:          64 (bytes into file)
  Start of section headers:          16552 (bytes into file)
  Flags:                             0x0
  Size of this header:               64 (bytes)
  Size of program headers:           56 (bytes)
  Number of program headers:         2
  Size of section headers:           64 (bytes)
  Number of section headers:         18
  Section header string table index: 17

@en-sc
Remove debug/test binary file
7bb0992 
The file was added by 00ab5f0 in riscv-software-src#567.
Seems like a mistake.
```
> readelf -h debug/test
ELF Header:
  Magic:   7f 45 4c 46 02 01 01 00 00 00 00 00 00 00 00 00
  Class:                             ELF64
  Data:                              2's complement, little endian
  Version:                           1 (current)
  OS/ABI:                            UNIX - System V
  ABI Version:                       0
  Type:                              EXEC (Executable file)
  Machine:                           RISC-V
  Version:                           0x1
  Entry point address:               0x1212340000
  Start of program headers:          64 (bytes into file)
  Start of section headers:          16552 (bytes into file)
  Flags:                             0x0
  Size of this header:               64 (bytes)
  Size of program headers:           56 (bytes)
  Number of program headers:         2
  Size of section headers:           64 (bytes)
  Number of section headers:         18
  Section header string table index: 17
```
@en-sc en-sc self-assigned this Aug 7, 2024
@en-sc en-sc requested a review from jerryz123 August 7, 2024 19:00
jerryz123
jerryz123 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry

aswaterman
aswaterman approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I should’ve noticed that in review.

@aswaterman aswaterman merged commit f2f748e into riscv-software-src:master Aug 7, 2024
2 checks passed
@en-sc en-sc deleted the en-sc/remove-test-bin branch August 7, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

@aswaterman aswaterman aswaterman approved these changes

Assignees

@en-sc en-sc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@en-sc @aswaterman @jerryz123