Add static type hints #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add static type hints, and switch to literals for some dicts to improve type inference (and it's nicer code anyway). This makes the code easier to understand and navigate, and also detected a few of bugs: 1. Missing brackets on `e.upper`. 2. `ext_name` may not exist on line 399 (I haven't fixed this). 3. Not strictly related to types, but a lot of the regexes were not raw strings and therefore contained invalid escape sequences. Python prints a warning about these in recent versions. It is currently not verified in CI by pyright, but that will come in a future MR. These changes were just verified by VSCode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add static type hints, and switch to literals for some dicts to improve type inference (and it's nicer code anyway).
This makes the code easier to understand and navigate, and also detected a few bugs:
e.upper.ext_namemay not exist on line 399 (I haven't fixed this).It is currently not verified in CI by pyright, but that will come in a future MR. These changes were just verified by VSCode.