feat: support retry for [statement|query] error
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Fu <[email protected]>
Signed-off-by: Eric Fu <[email protected]>
fuyufjh
force-pushed
the
eric/support_retry_for_statement_error
branch
from
85061fc to
dce9f1d
Compare
Signed-off-by: Eric Fu <[email protected]>
8 tasks
TennyZhuang
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #239 doesn't support
retryfor error query or statement. This is because any tokens after the[statement|query] errorare treated as error message regex.However, we found this case is useful. #239 (comment)
This PR adds support for
[statement|query] errorwith multiline message. As a compromise, the single-line syntax[statement|query] error <error message regex...>is not supported.