-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support alter shared source #18935
Draft
xxchan
wants to merge
1
commit into
main
Choose a base branch
from
09-17-feat_support_alter_shared_source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+208
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
from
October 16, 2024 06:52
7ee40ee
to
f74b951
Compare
12 tasks
xxchan
force-pushed
the
xxchan/share-source-config
branch
from
October 17, 2024 06:52
899a05f
to
7326f9d
Compare
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
from
October 17, 2024 06:52
f74b951
to
9c3cea6
Compare
xxchan
force-pushed
the
xxchan/share-source-config
branch
from
October 18, 2024 00:49
7326f9d
to
2bf03cd
Compare
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
from
October 18, 2024 00:49
9c3cea6
to
a7949b2
Compare
xxchan
force-pushed
the
xxchan/share-source-config
branch
from
October 21, 2024 01:40
2bf03cd
to
06bd105
Compare
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
from
October 21, 2024 01:40
a7949b2
to
975cc21
Compare
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
2 times, most recently
from
October 23, 2024 02:47
90d1fab
to
1c9feb2
Compare
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
2 times, most recently
from
October 30, 2024 02:19
d43372e
to
9bf7633
Compare
This was referenced Oct 30, 2024
xxchan
force-pushed
the
xxchan/refactor-ddl
branch
from
November 4, 2024 03:59
f33a42a
to
d43598b
Compare
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
from
November 4, 2024 03:59
9bf7633
to
c117687
Compare
xxchan
force-pushed
the
xxchan/refactor-ddl
branch
from
November 4, 2024 05:50
d43598b
to
0012e27
Compare
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
from
November 4, 2024 05:50
c117687
to
9be32c1
Compare
xxchan
force-pushed
the
xxchan/refactor-ddl
branch
from
November 4, 2024 05:59
0012e27
to
613044f
Compare
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
2 times, most recently
from
November 4, 2024 06:19
4acdc3b
to
42bb88c
Compare
- table with connector: filled when creating job catalog https://github.com/risingwavelabs/risingwave/blob/193e93fd8d9f9dbae717fe6a5b411e7f33382f27/src/meta/src/controller/streaming_job.rs#L247-L251 - stream node: filled in fill_job Signed-off-by: xxchan <[email protected]> feat: support alter shared source . Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
09-17-feat_support_alter_shared_source
branch
from
November 20, 2024 09:59
42bb88c
to
7e3529d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.