Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support alter shared source #18935

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Oct 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Oct 16, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch from 7ee40ee to f74b951 Compare October 16, 2024 06:52
@xxchan xxchan changed the base branch from main to xxchan/share-source-config October 16, 2024 06:52
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch from f74b951 to 9c3cea6 Compare October 17, 2024 06:52
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch from 9c3cea6 to a7949b2 Compare October 18, 2024 00:49
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch from a7949b2 to 975cc21 Compare October 21, 2024 01:40
Base automatically changed from xxchan/share-source-config to main October 21, 2024 02:34
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch 2 times, most recently from 90d1fab to 1c9feb2 Compare October 23, 2024 02:47
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch 2 times, most recently from d43372e to 9bf7633 Compare October 30, 2024 02:19
@xxchan xxchan changed the base branch from main to xxchan/refactor-ddl October 30, 2024 02:19
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch from 9bf7633 to c117687 Compare November 4, 2024 03:59
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch from c117687 to 9be32c1 Compare November 4, 2024 05:50
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch 2 times, most recently from 4acdc3b to 42bb88c Compare November 4, 2024 06:19
Base automatically changed from xxchan/refactor-ddl to main November 4, 2024 10:58
- table with connector: filled when creating job catalog https://github.com/risingwavelabs/risingwave/blob/193e93fd8d9f9dbae717fe6a5b411e7f33382f27/src/meta/src/controller/streaming_job.rs#L247-L251
- stream node: filled in fill_job

Signed-off-by: xxchan <[email protected]>

feat: support alter shared source

.

Signed-off-by: xxchan <[email protected]>
@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch from 42bb88c to 7e3529d Compare November 20, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant