Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pgwire): support struct type in extended mode #19450

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Nov 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #7949.

sqllogictest-rs doesn't support struct type yet, so I added a Python test in e2e-test.

References:

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Base automatically changed from eric/pgwire_support_1dim_list_binary to main November 19, 2024 09:38
@graphite-app graphite-app bot requested review from a team November 19, 2024 09:38
@fuyufjh fuyufjh force-pushed the eric/pgwire_binary_struct_type branch from 56bceb2 to 59b8c40 Compare November 20, 2024 07:49
@fuyufjh fuyufjh added this pull request to the merge queue Nov 20, 2024
@fuyufjh fuyufjh removed this pull request from the merge queue due to a manual request Nov 20, 2024
@fuyufjh fuyufjh added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit a0b65fd Nov 20, 2024
28 of 29 checks passed
@fuyufjh fuyufjh deleted the eric/pgwire_binary_struct_type branch November 20, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(frontend): pgwire binary response unimplemented for list and struct
2 participants