Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: shared source data loss (#19443) and rate limit (#19445, #19466) #19482

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Nov 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

cherry-pick: shared source data loss (#19443) and rate limit (#19445, #19466)

Also cherry-pick #19085: make the creating mvs visible in the rw_materialized_views catalog.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

graphite-app bot commented Nov 20, 2024

Graphite Automations

"release branch request review" took an action on this PR • (11/20/24)

1 reviewer was added to this PR based on xxchan's automation.

Signed-off-by: xxchan <[email protected]>
@xxchan
Copy link
Member Author

xxchan commented Nov 20, 2024

cc @kwannoel can I cherry-pick #19085 together?

meet a e2e test issue without that
image

@lmatz lmatz requested a review from cyliu0 November 20, 2024 09:04
@kwannoel
Copy link
Contributor

cc @kwannoel can I cherry-pick #19085 together?

meet a e2e test issue without that image

SGTM

@xxchan xxchan added this pull request to the merge queue Nov 20, 2024
Merged via the queue into release-2.1 with commit 79dbb2c Nov 20, 2024
26 of 27 checks passed
@xxchan xxchan deleted the xxchan/cp-2.1-ss branch November 20, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants