Apply filters when processing pedals

[lpugin]

Fixes #3880

• const_cast should be avoided, but needs refactoring of GetTstampStaves

[rettinghaus]

What about the case if @staff is missing and only @startid is being used?

[lpugin]

What about the case if @staff is missing and only @startid is being used?

See

verovio/include/vrv/timeinterface.h

Line 88 in bb23ff1

* Return a vector of staves looking at the @staff attribute or at the parent staff or the @startid

[brdvd]

Another glitch is that the pedal event is duplicated since the functor is repeated for each layer.

Not sure how to approach this. Probably it's not harmful and we can keep it for now. I'll have a look at the const-cast-issue.

[lpugin]

Another glitch is that the pedal event is duplicated since the functor is repeated for each layer.

Not sure how to approach this. Probably it's not harmful and we can keep it for now.

The easiest is to add a flag to the functor to indicate when Pedal should be processed or not. Alternatively we could check if there is a Layer filter - which is the case only once when the functor is processed, but that would probably be just more complicated.

I'll have a look at the const-cast-issue.

Thanks!

[brdvd]

The easiest is to add a flag to the functor to indicate when Pedal should be processed or not. Alternatively we could check if there is a Layer filter - which is the case only once when the functor is processed, but that would probably be just more complicated.

Yes, sounds good. This flag should actually effect the processing of any control elements.

[brdvd]

Looks great now, thank you!