Add LinkedIn Url to Officers Table/Model #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update nodemon * Update nodemailer & mailgun transport * Update sqlite * Update sequelize-cli * Add Make Keys Directory to README * Update nyc * Update bluebird, jsonwebtoken, mocha * Update mime, supertest, chai, cross-env, moment, morgan
BenAlderfer
reviewed
Oct 23, 2019
| @@ -33,6 +33,9 @@ export default sequelize.define('officers', { | |||
| type: DataTypes.DATE, | |||
| defaultValue: null, | |||
| }, | |||
| linkedinUrl: { | |||
| type: DataTypes.TEXT, | |||
There was a problem hiding this comment.
do you think it would be worth adding a field validator?
There was a problem hiding this comment.
I’ll validate that it’s a URL - that’s probably all we need. Since officers are the only ones using this, I trust that they’ll put a LinkedIn or similar URL here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend support for: rit-sse/OneRepoToRuleThemAll#261