Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 0.19.0 #868

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

dreulavelle
Copy link
Member

@dreulavelle dreulavelle commented Nov 6, 2024

🤖 I have created a release beep boop

0.19.0 (2024-11-14)

Features

  • add reindexing of movie/shows in unreleased or ongoing state (139d936)
  • added upload logs endpoint to be used by frontend (3ad6cae)
  • implement filesize validation for movies and episodes (#869) (d1041db)

Bug Fixes

  • added cleaner directory log when rebuilding symlinks (bb85517)
  • chunk initial symlinks on re-ingest (#882) (21cd393)
  • correct Prowlarr capabilities (#879) (f2636e4)
  • detecting multiple episodes in symlink library (#862) (ebd11fd)
  • disable reindexing. wip. change get items endpoint to use id instead of imdbid. (5123567)
  • more tweaks for scrapers and fine tuning. (b25658d)
  • re-check ongoing/unreleased items (#880) (47f23fa)
  • skip unindexable items when resetting db (98cb2c1)
  • update state filtering logic to allow 'All' as a valid state (#870) (4430d2d)
  • updated mediafusion and tweaked scrape func to be cleaner (73c0bcc)
  • updated torbox scraper to use api key. refactored scrapers slightly. added more logging to scrapers. (afdb9f6)

This PR was generated with Release Please. See documentation.

Summary by CodeRabbit

Release Notes for Version 0.19.0 (November 14, 2024)

  • New Features

    • Reindexing of movies and shows in unreleased or ongoing states.
    • Upload logs endpoint for frontend integration.
    • Filesize validation for movies and episodes.
  • Bug Fixes

    • Cleaner directory log when rebuilding symlinks.
    • Improved chunking of initial symlinks on re-ingest.
    • Enhanced detection of multiple episodes in the symlink library.
    • State filtering logic updated to allow 'All' as a valid state.
    • Various tweaks and improvements to scrapers for better performance.

Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the project documentation and versioning. The CHANGELOG.md file has been revised to include a new version entry for 0.19.0, dated November 14, 2024, detailing new features such as reindexing of movies and shows, an upload logs endpoint, and filesize validation, along with various bug fixes. The pyproject.toml file reflects an increment in the project version from 0.18.0 to 0.19.0, while all other sections remain unchanged.

Changes

File Change Summary
CHANGELOG.md Added entry for version 0.19.0, documenting new features including reindexing of movies/shows, upload logs endpoint, filesize validation, and multiple bug fixes.
pyproject.toml Updated version from 0.18.0 to 0.19.0; no changes to dependencies.

Possibly related PRs

  • chore(main): release 0.19.0 #868: This PR is directly related as it introduces the same version (0.19.0) and includes several features and bug fixes that are also mentioned in the main PR summary, such as reindexing of movies and shows, an upload logs endpoint, and filesize validation.

Suggested labels

autorelease: pending

Suggested reviewers

  • Gaisberg
  • iPromKnight

Poem

In the meadow, logs we send,
A new version, our work to mend.
With each update, we hop and play,
Bringing features to brighten the day!
So let’s cheer for version zero point one nine,
A joyful leap, all is fine! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
pyproject.toml (1)

Line range hint 9-89: Consider upgrading some dependencies for security and features.

Several dependencies could benefit from updates:

  1. requests-cache (1.2.1) and requests-ratelimiter (0.7.0) - These are crucial for the new logs endpoint to prevent overwhelming the system
  2. prometheus-client (0.20.0) - Important for monitoring the logs endpoint performance

Consider updating these in a future maintenance PR to ensure optimal performance and security of the new logs endpoint.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3ad6cae and 7caa8a8.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🔇 Additional comments (4)
pyproject.toml (2)

3-3: Version bump looks appropriate.

The version increment from 0.18.0 to 0.19.0 follows semantic versioning and aligns with the addition of the new upload logs endpoint feature.


Line range hint 1-89: Verify logging-related dependencies for the new upload logs endpoint.

The project has several logging-related dependencies that should support the new upload logs endpoint:

  • loguru (^0.7.2)
  • opentelemetry-api (^1.25.0)
  • opentelemetry-sdk (^1.25.0)
  • opentelemetry-exporter-prometheus (^0.46b0)

Let's verify the implementation of the new logs endpoint:

✅ Verification successful

The logging dependencies are properly configured and utilized for the upload logs endpoint

The verification confirms that:

  • The upload logs endpoint is implemented in src/routers/secure/default.py using loguru for logging
  • Loguru is widely used across the codebase (45+ files)
  • The endpoint properly handles log file access and error logging
  • Logging is configured with both stderr and file handlers

While OpenTelemetry dependencies are present in pyproject.toml, they appear to be for metrics/monitoring rather than the log upload functionality, which correctly uses loguru.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for the new upload logs endpoint implementation and its dependencies

# Test 1: Look for the new endpoint implementation
echo "Searching for upload logs endpoint implementation..."
rg -l "upload.*logs?" --type py

# Test 2: Check usage of logging libraries in the codebase
echo "Checking logging library usage..."
rg -l "from loguru import" --type py
rg -l "from opentelemetry" --type py

Length of output: 2198


Script:

#!/bin/bash
# Let's examine the upload logs endpoint implementation and its logging usage

# Check the implementation details of the upload logs endpoint
echo "Examining upload logs endpoint in default.py..."
rg -A 10 "upload.*logs?" src/routers/secure/default.py

# Check how logging is configured in the project
echo "Checking logging configuration..."
rg -A 10 "logger.*config|logging.*setup" src/program/utils/logging.py

# Check OpenTelemetry setup
echo "Checking OpenTelemetry setup..."
rg -A 10 "opentelemetry" src/main.py

Length of output: 1627

CHANGELOG.md (2)

3-4: LGTM! Version header follows conventional format.

The version header correctly includes:

  • Version number with semantic versioning
  • GitHub comparison link
  • Release date

6-8: LGTM! Feature entry follows conventional format.

The feature entry correctly:

  • Uses bullet point format
  • Includes commit hash link
  • Follows conventional commit message format

@dreulavelle dreulavelle force-pushed the release-please--branches--main branch 5 times, most recently from 40f9f33 to 5593dfc Compare November 9, 2024 04:22
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

14-14: Consider hyphenating "fine-tuning".

For consistency with standard English compound modifiers, consider updating:

-* more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmedia/riven/commit/b25658d21a43d2e0a097abf608c7a96216ed90ec))
+* more tweaks for scrapers and fine-tuning. ([b25658d](https://github.com/rivenmedia/riven/commit/b25658d21a43d2e0a097abf608c7a96216ed90ec))
🧰 Tools
🪛 LanguageTool

[misspelling] ~14-~14: This word is normally spelled with a hyphen.
Context: ...99e14e)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 40f9f33 and 5593dfc.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[misspelling] ~14-~14: This word is normally spelled with a hyphen.
Context: ...99e14e)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

🔇 Additional comments (1)
CHANGELOG.md (1)

3-17: LGTM! The changelog follows the conventional format.

The changelog is well-structured with clear sections for features and bug fixes, proper version numbering, and helpful links to commits and issues.

🧰 Tools
🪛 LanguageTool

[misspelling] ~14-~14: This word is normally spelled with a hyphen.
Context: ...99e14e)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

@dreulavelle dreulavelle force-pushed the release-please--branches--main branch from 5593dfc to b48f63a Compare November 9, 2024 21:54
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

15-15: Consider hyphenating "fine-tuning" in the commit message.

The term "fine tuning" is typically hyphenated when used as a compound modifier.

🧰 Tools
🪛 LanguageTool

[misspelling] ~15-~15: This word is normally spelled with a hyphen.
Context: ...99e14e)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5593dfc and b48f63a.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[misspelling] ~15-~15: This word is normally spelled with a hyphen.
Context: ...99e14e)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

🔇 Additional comments (1)
CHANGELOG.md (1)

3-18: LGTM! The changelog entry for version 0.19.0 is well-structured and complete.

The changelog entry follows best practices:

  • Clear categorization into Features and Bug Fixes
  • Proper linking of commit hashes and issues
  • Consistent formatting throughout
  • Changes align with the PR objectives
🧰 Tools
🪛 LanguageTool

[misspelling] ~15-~15: This word is normally spelled with a hyphen.
Context: ...99e14e)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

@dreulavelle dreulavelle force-pushed the release-please--branches--main branch from b48f63a to d2449d7 Compare November 11, 2024 02:40
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
CHANGELOG.md (2)

6-10: Consider enhancing feature descriptions.

While the features are properly documented with commit links, consider adding more context about:

  • The purpose and impact of reindexing unreleased/ongoing items
  • The use cases and benefits of the upload logs endpoint

Example enhancement:

-* add reindexing of movie/shows in unreleased or ongoing state
+* add reindexing capability for movies and shows that are either unreleased or in an ongoing state, improving content tracking
-* added upload logs endpoint to be used by frontend
+* added upload logs endpoint to enable frontend access to system logs, improving debugging and monitoring capabilities

12-19: Improve bug fix descriptions and fix hyphenation.

  1. The term "fine tuning" should be hyphenated as "fine-tuning"
  2. Some bug fix descriptions could be more specific about the problems they solved

Apply these improvements:

-* more tweaks for scrapers and fine tuning.
+* more tweaks for scrapers and fine-tuning to improve scraping accuracy
-* updated mediafusion and tweaked scrape func to be cleaner
+* updated mediafusion scraper and refactored scraping function for improved maintainability
-* updated torbox scraper to use api key. refactored scrapers slightly. added more logging to scrapers.
+* updated torbox scraper to use API key for authentication, refactored scrapers for consistency, and enhanced logging for better debugging
🧰 Tools
🪛 LanguageTool

[misspelling] ~16-~16: This word is normally spelled with a hyphen.
Context: ...99e14e)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b48f63a and d2449d7.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[misspelling] ~16-~16: This word is normally spelled with a hyphen.
Context: ...99e14e)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

🔇 Additional comments (1)
CHANGELOG.md (1)

3-5: LGTM! Version header follows the standard format.

The version header is well-structured with:

  • Semantic version number
  • GitHub compare URL
  • ISO formatted release date

@dreulavelle dreulavelle force-pushed the release-please--branches--main branch from d2449d7 to 5075eeb Compare November 11, 2024 05:41
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

12-20: Add hyphen to "fine-tuning".

The bug fixes are well-documented, but there's a minor grammatical improvement needed.

Apply this diff to fix the hyphenation:

-* more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmedia/riven/commit/b25658d21a43d2e0a097abf608c7a96216ed90ec))
+* more tweaks for scrapers and fine-tuning. ([b25658d](https://github.com/rivenmedia/riven/commit/b25658d21a43d2e0a097abf608c7a96216ed90ec))
🧰 Tools
🪛 LanguageTool

[misspelling] ~17-~17: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d2449d7 and 5075eeb.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[misspelling] ~17-~17: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

🔇 Additional comments (2)
CHANGELOG.md (2)

3-5: LGTM! Version header follows the Keep a Changelog format.

The version header is properly formatted with the correct version number, GitHub compare URL, and release date.


6-10: LGTM! Features section is well-documented.

Each feature is properly documented with:

  • Clear descriptions of the changes
  • Properly formatted commit links

@dreulavelle dreulavelle force-pushed the release-please--branches--main branch 2 times, most recently from 44d98a3 to 5b5c721 Compare November 12, 2024 00:49
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

6-10: LGTM! Features are well-documented.

Features are clearly described with proper commit references.

Consider using a hyphen in "fine-tuning" in commit messages for consistency with standard English compound words.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5075eeb and 44d98a3.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[misspelling] ~17-~17: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

🔇 Additional comments (2)
CHANGELOG.md (2)

3-5: LGTM! Version header is well-formatted.

The version header follows changelog conventions with proper GitHub comparison link and release date.


12-21: LGTM! Bug fixes are well-documented.

Bug fixes are properly documented with:

🧰 Tools
🪛 LanguageTool

[misspelling] ~17-~17: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

8-21: Maintain consistent commit message formatting.

The commit messages in version 0.19.0 have inconsistent formatting:

  • Some messages end with periods while others don't
  • Mixed usage of imperative mood and past tense

Consider standardizing the commit messages to:

  • Use imperative mood (e.g., "add" instead of "added")
  • Remove trailing periods
  • Start with lowercase

Example fixes:

-* added upload logs endpoint to be used by frontend ([3ad6cae])
+* add upload logs endpoint for frontend use ([3ad6cae])
-* more tweaks for scrapers and fine tuning. ([b25658d])
+* tweak scrapers and fine-tune ([b25658d])
🧰 Tools
🪛 LanguageTool

[misspelling] ~17-~17: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 44d98a3 and 5b5c721.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[misspelling] ~17-~17: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

🔇 Additional comments (1)
CHANGELOG.md (1)

1-24: Well-structured changelog format.

The changelog follows the Keep a Changelog format with clear version headers, comparison links, dates, and categorized changes.

🧰 Tools
🪛 LanguageTool

[misspelling] ~17-~17: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

@dreulavelle dreulavelle force-pushed the release-please--branches--main branch 2 times, most recently from c3c1aed to 7ae6c0f Compare November 13, 2024 16:27
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
CHANGELOG.md (2)

19-19: Fix hyphenation in changelog entry.

The term "fine tuning" should be hyphenated when used as a compound modifier.

-* more tweaks for scrapers and fine tuning. ([b25658d])
+* more tweaks for scrapers and fine-tuning. ([b25658d])
🧰 Tools
🪛 LanguageTool

[misspelling] ~19-~19: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)


15-23: Add more context about impact in changelog entries.

Several bug fix entries would benefit from additional context about their impact. Consider expanding these entries:

-* added cleaner directory log when rebuilding symlinks ([bb85517])
+* improved logging clarity: add detailed directory logs during symlink rebuilding process ([bb85517])

-* skip unindexable items when resetting db ([98cb2c1])
+* performance improvement: skip processing of unindexable items during database reset to reduce unnecessary operations ([98cb2c1])

-* updated torbox scraper to use api key. refactored scrapers slightly. added more logging to scrapers. ([afdb9f6])
+* security enhancement: update torbox scraper to use API key authentication
+* maintenance: refactor scrapers for better maintainability
+* observability: add comprehensive logging to all scrapers ([afdb9f6])
🧰 Tools
🪛 LanguageTool

[misspelling] ~19-~19: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5b5c721 and 7ae6c0f.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[misspelling] ~19-~19: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

* added cleaner directory log when rebuilding symlinks ([bb85517](https://github.com/rivenmedia/riven/commit/bb85517197bf10e855c1cfaa41e0d765dfd298e1))
* correct Prowlarr capabilities ([#879](https://github.com/rivenmedia/riven/issues/879)) ([f2636e4](https://github.com/rivenmedia/riven/commit/f2636e408f66a730915cfb2f49f56e38b1faf8c9))
* detecting multiple episodes in symlink library ([#862](https://github.com/rivenmedia/riven/issues/862)) ([ebd11fd](https://github.com/rivenmedia/riven/commit/ebd11fd7d94a7763f0869bde6ed9b545d499e14e))
* disable reindexing. wip. change get items endpoint to use id instead of imdbid. ([5123567](https://github.com/rivenmedia/riven/commit/5123567d4fe9ce8ef65d4fc09fa130d19a714ef7))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve changelog entry clarity and completeness.

The entry contains "wip" and combines multiple unrelated changes into a single line. Consider splitting and clarifying:

-* disable reindexing. wip. change get items endpoint to use id instead of imdbid. ([5123567])
+* refactor: change get items endpoint to use ID instead of IMDB ID for better consistency ([5123567])
+* chore: temporarily disable reindexing feature ([5123567])
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* disable reindexing. wip. change get items endpoint to use id instead of imdbid. ([5123567](https://github.com/rivenmedia/riven/commit/5123567d4fe9ce8ef65d4fc09fa130d19a714ef7))
* refactor: change get items endpoint to use ID instead of IMDB ID for better consistency ([5123567](https://github.com/rivenmedia/riven/commit/5123567d4fe9ce8ef65d4fc09fa130d19a714ef7))
* chore: temporarily disable reindexing feature ([5123567](https://github.com/rivenmedia/riven/commit/5123567d4fe9ce8ef65d4fc09fa130d19a714ef7))

@dreulavelle dreulavelle force-pushed the release-please--branches--main branch from 7ae6c0f to e69897e Compare November 14, 2024 08:00
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7ae6c0f and e69897e.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[misspelling] ~19-~19: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

🔇 Additional comments (1)
CHANGELOG.md (1)

18-18: Previous review comment is still applicable.

The changelog entry needs improvement as previously noted.

* correct Prowlarr capabilities ([#879](https://github.com/rivenmedia/riven/issues/879)) ([f2636e4](https://github.com/rivenmedia/riven/commit/f2636e408f66a730915cfb2f49f56e38b1faf8c9))
* detecting multiple episodes in symlink library ([#862](https://github.com/rivenmedia/riven/issues/862)) ([ebd11fd](https://github.com/rivenmedia/riven/commit/ebd11fd7d94a7763f0869bde6ed9b545d499e14e))
* disable reindexing. wip. change get items endpoint to use id instead of imdbid. ([5123567](https://github.com/rivenmedia/riven/commit/5123567d4fe9ce8ef65d4fc09fa130d19a714ef7))
* more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmedia/riven/commit/b25658d21a43d2e0a097abf608c7a96216ed90ec))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve changelog entry clarity and consistency.

The current entry is vague and has formatting inconsistencies:

  1. Specify which scrapers were tweaked and what was fine-tuned
  2. Remove the trailing period for consistency with other entries
  3. Hyphenate "fine-tuning"
-* more tweaks for scrapers and fine tuning. ([b25658d])
+* improve scraper performance with fine-tuning optimizations ([b25658d])
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmedia/riven/commit/b25658d21a43d2e0a097abf608c7a96216ed90ec))
* improve scraper performance with fine-tuning optimizations ([b25658d](https://github.com/rivenmedia/riven/commit/b25658d21a43d2e0a097abf608c7a96216ed90ec))
🧰 Tools
🪛 LanguageTool

[misspelling] ~19-~19: This word is normally spelled with a hyphen.
Context: ...714ef7)) * more tweaks for scrapers and fine tuning. ([b25658d](https://github.com/rivenmed...

(EN_COMPOUNDS_FINE_TUNING)

* skip unindexable items when resetting db ([98cb2c1](https://github.com/rivenmedia/riven/commit/98cb2c12acc40fd2f2c12f79af247f89aa5638fa))
* update state filtering logic to allow 'All' as a valid state ([#870](https://github.com/rivenmedia/riven/issues/870)) ([4430d2d](https://github.com/rivenmedia/riven/commit/4430d2daf682f26b9141a3130fa869524840a2d9))
* updated mediafusion and tweaked scrape func to be cleaner ([73c0bcc](https://github.com/rivenmedia/riven/commit/73c0bcc91eb99c4825764775e986057951c713ae))
* updated torbox scraper to use api key. refactored scrapers slightly. added more logging to scrapers. ([afdb9f6](https://github.com/rivenmedia/riven/commit/afdb9f6f202690dae9b04e7d2c8ce5e078b94d0c))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Split changelog entry into separate items.

Multiple significant changes are combined into a single entry. Consider splitting them for better clarity and tracking.

-* updated torbox scraper to use api key. refactored scrapers slightly. added more logging to scrapers. ([afdb9f6])
+* update torbox scraper to use API key ([afdb9f6])
+* refactor scrapers for improved maintainability ([afdb9f6])
+* enhance scraper logging for better debugging ([afdb9f6])
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* updated torbox scraper to use api key. refactored scrapers slightly. added more logging to scrapers. ([afdb9f6](https://github.com/rivenmedia/riven/commit/afdb9f6f202690dae9b04e7d2c8ce5e078b94d0c))
* update torbox scraper to use API key ([afdb9f6](https://github.com/rivenmedia/riven/commit/afdb9f6f202690dae9b04e7d2c8ce5e078b94d0c))
* refactor scrapers for improved maintainability ([afdb9f6](https://github.com/rivenmedia/riven/commit/afdb9f6f202690dae9b04e7d2c8ce5e078b94d0c))
* enhance scraper logging for better debugging ([afdb9f6](https://github.com/rivenmedia/riven/commit/afdb9f6f202690dae9b04e7d2c8ce5e078b94d0c))

@dreulavelle dreulavelle force-pushed the release-please--branches--main branch from e69897e to 58142fa Compare November 14, 2024 20:20
@dreulavelle dreulavelle force-pushed the release-please--branches--main branch from 58142fa to 996166f Compare November 14, 2024 22:13
@dreulavelle dreulavelle merged commit 24ee3d8 into main Nov 14, 2024
1 of 2 checks passed
@dreulavelle dreulavelle deleted the release-please--branches--main branch November 14, 2024 22:15
@dreulavelle
Copy link
Member Author

🤖 Created releases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant