Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: use between in getMiniblocks query #1302

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

sdk: use between in getMiniblocks query #1302

wants to merge 4 commits into from

Conversation

miguel-nascimento
Copy link
Contributor

@miguel-nascimento miguel-nascimento commented Oct 21, 2024 •
edited
Loading

now

time-getMiniblocks-202d19b13129e6e045200101882169308671f4b3470000000000000000000000: 18.329833984375 ms
time-getMiniblocks-202d19b13129e6e045200101882169308671f4b3470000000000000000000000: 150.27294921875 ms
time-getMiniblocks-202d19b13129e6e045200101882169308671f4b3470000000000000000000000: 151.60986328125 ms
time-getMiniblocks-202d19b13129e6e045200101882169308671f4b3470000000000000000000000: 185.18505859375 ms

previously:

time-getMiniblocks-202d19b13129e6e045200101882169308671f4b3470000000000000000000000: 76.501953125 ms
time-getMiniblocks-202d19b13129e6e045200101882169308671f4b3470000000000000000000000: 199.236083984375 ms
time-getMiniblocks-202d19b13129e6e045200101882169308671f4b3470000000000000000000000: 171.22900390625 ms
time-getMiniblocks-202d19b13129e6e045200101882169308671f4b3470000000000000000000000: 313.4970703125 ms

@miguel-nascimento miguel-nascimento enabled auto-merge (squash) October 24, 2024 02:45
erikolsson
erikolsson approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@erikolsson erikolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @miguel-nascimento !

@miguel-nascimento
Copy link
Contributor Author

shareKeysWithNewDevices keeps falling here.
Also Im failing to decrypt messages in some channels on the app - unsure if related

texuf
texuf reviewed Nov 7, 2024
View reviewed changes
packages/sdk/src/persistenceStore.ts
}
miniblocks.push(parsedMiniblock)
}
return miniblocks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update this to miniblocks.length === (rangeEnd-rangeStart) ? miniblocks : []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texuf texuf texuf approved these changes

@erikolsson erikolsson erikolsson approved these changes

@sergekh2 sergekh2 Awaiting requested review from sergekh2 sergekh2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguel-nascimento @erikolsson @texuf