Tags: riversand963/mysql-5.6
Tags
Apply admission checks only once for multi query packet Summary: Initial version of admission control applied limits on each query statement in multi query packet. The behavior is modified to the following: A thread enters admission control when executing the first non-filtered command in the multi query packet and exits after executing all the query statements in the multi query packet. This diff also fixes a bug where admission control limits are not initialized during mysqld startup. Squash with https://reviews.facebook.net/D48405 Test Plan: mtr Reviewers: tianx, jkedgar Reviewed By: jkedgar Subscribers: davidgoode, webscalesql-eng, domas Differential Revision: https://reviews.facebook.net/D56517 (cherry picked from commit bcbd77a)
Decrement nesting level when object is closed Summary: If an object or array is parsed successfully, deprecent the nesting_lvl_ count Squash with 090d736 [DocStore] Add limit on JSON object/array nesting levels Test Plan: run unit tests ✓ fbson/test:fbson_parser_test - FBSON_PARSER.nesting_level 0.000s (PASS) Reviewers: pengt, tianx Reviewed By: tianx Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D56187 (cherry picked from commit cbc1670)
Remove the usage of returns_nonnull to make sure that we'll compile w… …ith gcc 4.8.x again Summary: The issue was exposed by facebook#207. The root cause is the fact that gcc 4.8.x doesn't implement a support for `returns_nonnull`. Take a look at https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Function-Attributes.html vs. https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/Function-Attributes.html. For last couple of months we've been operating under the assumption that gcc 4.9.x is the lowest supported platform. We need to go back and internally either revisit this decision or be very explicit about our dependency requirements. Test Plan: Optimistic fix, needs to be really verified on the system running gcc 4.8.x. ``` mysqlbuild.sh ``` Reviewers: yoshinorim, MarkCallaghan Reviewed By: MarkCallaghan Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D55641 (cherry picked from commit 76887a2)
Make 'SKIP', 'LOCKED', and 'NOWAIT' non-reserved key words Summary: When SELECT ... FOR UDPATE [SKIP LOCKED | NOWAIT] was introduced, 'SKIP', 'LOCKED', and 'NOWAIT' were made as reserved key words, which caused some existing SQL which access columns with name 'skip', 'locked', or 'nowait' being rejected with syntax errors. This diff fixes this issue by making these three key words non-reserved. Squash with: 193896c https://reviews.facebook.net/D53913 Test Plan: Added new tests in innodb.innodb_lock_skip_locked_nowait.test Reviewers: tianx Reviewed By: tianx Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D55533
New Valgrind Suppression for RocksDB Summary: Updated the valgrind suppression for RocksDB due to a function symbol name change. Reproducible with mysqltest.sh --valgrind innodb_stress.innodb_stress_crash Test Plan: mysqltest.sh --valgrind innodb_stress.innodb_stress_crash arc diff --big-test-queue Reviewers: hermanlee4, mung, jkedgar Reviewed By: jkedgar Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D55389 (cherry picked from commit 39bdd23)
Fix time granularity in dump thread Summary: Dump thread used second granularity to decide whether heartbeat needs to be sent to slaves. With milli-second heartbeat configuration on slaves, this caused dump thread to send heartbeat events for every skipped event. This significantly increases slave start time. Fix this by increasing the granularity. Test Plan: mtr Set millisecond heartbeat and auto_position on slave. Verify the time where SQL thread started progressing is not insanely high Reviewers: pengt, hermanlee4, tianx Reviewed By: tianx Subscribers: webscalesql-eng, tengli Differential Revision: https://reviews.facebook.net/D55281
Workaround for xtrabackup hitting problems with O_DIRECT and logfiles Summary: 5.6.27 introduced a change in the open file call to set the O_DIRECT flag on all file types, including log files. When xtrabackup tries to modify the ib_logfile by reading a 2K block into a 2K aligned buffer, it hits errors with 4K file block sizes. This diff removes the code for xtrabackup builds. Test Plan: Verify xtrabackup completes successfully. Reviewers: jtolmer, jkedgar Reviewed By: jkedgar Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D54771
Add retry option when receiving kBusy on first row after snapshot Summary: When there is contention on rows that causes kBusy errors if this occurs on the first row since we created a snapshot we can release the snapshot (and iterator) and retry to avoid returning too many deadlock errors. Test Plan: MTR Reviewers: spetrunia, yoshinorim, hermanlee4 Reviewed By: hermanlee4 Subscribers: spetrunia, webscalesql-eng Differential Revision: https://reviews.facebook.net/D54231
Lift \u0000 constraint in JSON parsing for backward compatibility Summary: This is to lift a unicode constraint to allow \u0000 (null) in the JSON string, for backward data compatibility. Test Plan: Jenkins Reviewers: pengt Reviewed By: pengt Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D54543 (cherry picked from commit 01876b2)
PreviousNext