Use pre-v5 enum names which are now supported by compatibility macros. #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested review from
wargio,
XVilka,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
5 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Blind fix, but this is very likely the reason for the endian issue: |
wargio
approved these changes
Oct 27, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Rot127
force-pushed
the
dist-fuzz-capstone-pre-v6-fixes
branch
from
9ed7fa8 to
73e7288
Compare
Rot127
force-pushed
the
dist-fuzz-capstone-pre-v6-fixes
branch
from
566eaa5 to
6102c53
Compare
XVilka
approved these changes
Oct 28, 2024
|
@Rot127 that PR still didn't help to resolve that endianess issue. |
|
Damn, was hoping I get around building qemu all over again. |
|
capstone-engine/capstone#2530 Sorry, of course I missed the obvious. |
XVilka
approved these changes
Oct 29, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQUASH ME
Your checklist for this pull request
Detailed description
Supersedes #4690
Test plan
...
Closing issues
...