Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Chart.build.xml #623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed Chart.build.xml #623

wants to merge 1 commit into from

Conversation

pcanelas
Copy link
Contributor

Hi,

When trying to run defects4j on Chart 1, it raised the following error:

compile:
    [mkdir] Created dir: /tmp/Chart_2/build
    [javac] /defects4j/framework/projects/Chart/Chart.build.xml:57: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
    [javac] Compiling 654 source files to /tmp/Chart_2/build
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 6
    [javac] warning: [options] source value 6 is obsolete and will be removed in a future release
    [javac] warning: [options] target value 1.6 is obsolete and will be removed in a future release
    [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
    [javac] /tmp/Chart_2/source/org/jfree/chart/axis/Axis.java:1152: error: unmappable character (0xC2) for encoding US-ASCII
    [javac]             return;  // no need to create entity if we can??t save it anyways...
    [javac]                                                           ^
    [javac] /tmp/Chart_2/source/org/jfree/chart/axis/Axis.java:1152: error: unmappable character (0xB4) for encoding US-ASCII
    [javac]             return;  // no need to create entity if we can??t save it anyways...
    [javac]                                                            ^
    [javac] 2 errors
    [javac] 4 warnings

BUILD FAILED
/defects4j/framework/projects/Chart/Chart.build.xml:57: Compile failed; see the compiler error output for details.

Adding encoding="UTF-8" to the compilation should address the issue.

@rjust
Copy link
Owner

rjust commented Oct 23, 2024

@pcanelas Thanks for the PR.

Just to clarify, is your default encoding US-ASCII, and this is the reason for the observed compilation error?

@pcanelas
Copy link
Contributor Author

pcanelas commented Nov 3, 2024

Ahm, I believe so, I am using Docker.

@rjust
Copy link
Owner

rjust commented Nov 3, 2024

Thanks, @pcanelas.

This change should be fine, given that it encodes what should be the default encoding.

@mernst and @markro49 Do you see any potential issues with this change?

@rjust rjust requested review from mernst and markro49 November 3, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants