Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlated LP SFs #74

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Correlated LP SFs #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 30 additions & 13 deletions src/HHbbVV/postprocessing/CreateDatacard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,6 @@
),
}

# LP SFs - uncorrelated across regions to be more conservative (?)
for sr in signal_regions:
for sig_key in sig_keys:
# values will be added in from the systematics JSON
nuisance_params[f"{CMS_PARAMS_LABEL}_lp_sf_{sr}_{mc_samples[sig_key]}"] = Syst(
prior="lnN", samples=[sig_key], regions=[sr]
)

if args.year != "all":
# remove other years' keys
for key in [
Expand All @@ -309,6 +301,29 @@
param: rl.NuisanceParameter(param, syst.prior) for param, syst in nuisance_params.items()
}

lpsf_params = {}

# LP SFs - uncorrelated across regions to be more conservative (?)
for sr in signal_regions:
lpsf_params[sr] = {}

# first add a single nuisance parameter per region and production mode
for sig_keys_prodmode, pmlabel in [(nonres_sig_keys_ggf, "ggf"), (nonres_sig_keys_vbf, "vbf")]:
# check if any signals from this production mode
if any(sig_key in sig_keys_prodmode for sig_key in sig_keys):
pname = f"{CMS_PARAMS_LABEL}_lp_sf_{sr}_{pmlabel}"
lpsf_params[sr][pmlabel] = rl.NuisanceParameter(pname, "lnN")

# fill nuisance dictionary, but same NuisanceParameter object for each region + prod mode
for sig_key in sig_keys:
# values will be added in from the systematics JSON
pname = f"{CMS_PARAMS_LABEL}_lp_sf_{sr}_{mc_samples[sig_key]}"
pmlabel = "ggf" if sig_key in nonres_sig_keys_ggf else "vbf"

nuisance_params[pname] = Syst(prior="lnN", samples=[sig_key], regions=[sr])
nuisance_params_dict[pname] = lpsf_params[sr][pmlabel]


# TODO: pileupID, lepton IDs (probably not necessary)

# dictionary of correlated shape systematics: name in templates -> name in cards, etc.
Expand Down Expand Up @@ -496,6 +511,7 @@ def process_systematics_combined(systematics: dict):

print("Nuisance Parameters")
pprint.pprint(nuisance_params)
pprint.pprint(nuisance_params_dict)


def process_systematics_separate(bg_systs: dict, sig_systs: dict[str, dict]):
Expand All @@ -505,6 +521,7 @@ def process_systematics_separate(bg_systs: dict, sig_systs: dict[str, dict]):

print("Nuisance Parameters")
pprint.pprint(nuisance_params)
pprint.pprint(nuisance_params_dict)


def process_systematics(templates_dir: str, sig_separate: bool):
Expand Down Expand Up @@ -617,7 +634,7 @@ def fill_regions(
blind_str = MCB_LABEL if region.endswith(MCB_LABEL) else ""

print("\n\n")
logging.info("starting region: %s" % region)
logging.info(f"starting region: {region}")
binstr = "" if mX_bin is None else f"mXbin{mX_bin}"
ch = rl.Channel(binstr + region.replace("_", "")) # can't have '_'s in name
model.addChannel(ch)
Expand All @@ -638,7 +655,7 @@ def fill_regions(
logging.info(f"Skipping ST in {region} region")
continue

logging.info("Getting templates for: %s" % sample_name)
logging.info(f"Getting templates for: {sample_name}")

sample_template = region_templates[sample_name, :]

Expand Down Expand Up @@ -834,7 +851,7 @@ def nonres_alphabet_fit(
for sample in failCh:
if sample.sampletype == rl.Sample.SIGNAL:
continue
logging.debug("Subtracting %s from qcd" % sample._name)
logging.debug(f"Subtracting {sample._name} from qcd")
initial_qcd -= sample.getExpectation(nominal=True)

if np.any(initial_qcd < 0.0):
Expand Down Expand Up @@ -961,7 +978,7 @@ def res_alphabet_fit(
# was integer, and numpy complained about subtracting float from it
initial_qcd = failCh.getObservation().astype(float)
for sample in failCh:
logging.debug("subtracting %s from qcd" % sample._name)
logging.debug(f"subtracting {sample._name} from qcd")
initial_qcd -= sample.getExpectation(nominal=True)

if np.any(initial_qcd < 0.0):
Expand Down Expand Up @@ -1111,7 +1128,7 @@ def get_systematics_abcd(channels, channels_dict, channels_summed, rates_dict):
channel_systs_dict = {}

for region in channels:
logging.info("starting region: %s" % region)
logging.info(f"starting region: {region}")

channel_systs_dict[region] = {}

Expand Down
4 changes: 2 additions & 2 deletions src/HHbbVV/processors/corrections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,10 +791,10 @@ def _np_pad(arr: np.ndarray, target: int = MAX_PT_FPARAMS):
def _get_flat_lp_vars(lds, kt_subjets_pt):
if len(lds) != 1:
# flatten and save offsets to unflatten afterwards
if type(lds.layout) == ak._ext.ListOffsetArray64:
if type(lds.layout) is ak._ext.ListOffsetArray64:
ld_offsets = lds.kt.layout.offsets
flat_subjet_pt = ak.flatten(kt_subjets_pt)
elif type(lds.layout) == ak._ext.ListArray64:
elif type(lds.layout) is ak._ext.ListArray64:
ld_offsets = lds.layout.toListOffsetArray64(False).offsets
flat_subjet_pt = kt_subjets_pt
else:
Expand Down
Loading