Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_route_params_parse #131

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

hpp0hpp
Copy link
Contributor

@hpp0hpp hpp0hpp commented Aug 26, 2024

fix the issue: #130

@rknell
Copy link
Owner

rknell commented Jan 5, 2025

Thank you for the PR addressing issue #130. However, the current implementation introduces several test failures: 1. Route parameter matching is broken for: - Custom typed parameters - Basic route parameters - Parameter extraction. While using Uri.decodeFull might fix the non-ASCII character decoding issue, it breaks the existing route parameter functionality. We need to: 1. Keep the special handling for slashes (which the original DecodeMode.AllButSlash provided) 2. Fix the non-ASCII character decoding 3. Maintain backward compatibility with existing route parameter behavior. Could you please update the PR to: 1. Add a test case for the non-ASCII character scenario from issue #130 2. Fix the implementation to handle both ASCII and non-ASCII cases correctly 3. Ensure all existing tests pass. Let me know if you need any help with the implementation.

@rknell rknell merged commit 3d5e36d into rknell:master Jan 6, 2025
rknell added a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants