Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpnigeria #9

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Cpnigeria #9

wants to merge 13 commits into from

Conversation

bmlancien
Copy link
Collaborator

Hi @Bachibouzouk, I did a few changes. I hope this will help you. I was not able to do a lot and also I hope the changes are correct because I cannot see the final result on the app... So let me know if there's any issue. I used 4,5 hours until now for that.

Below the mockup of how the scenario design could look like:

iPad Pro 12 9_ - 1

And how the step 5 too:

iPad Pro 12 9_ - 2

@bmlancien bmlancien requested a review from Bachibouzouk October 4, 2023 10:48
@@ -4,13 +4,15 @@
.project-setup.two-columns {
@include flex-row-justify-center;
padding-bottom: 6rem;
flex: 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tells me that the parent container is not display: flex so this option is not applied here, I moved it into .left, .right and it worked

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right, I think that was a mistake of mine.

@@ -9,6 +9,7 @@
.left,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I scroll down the map goes over the navbar, what should I do to change this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know once you've implemented the changes so I can check what's the issue. I won't be able to check it before tomorrow, though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try .right .map { z-index: 1 }
I think it should work.

@bmlancien
Copy link
Collaborator Author

Hi @Bachibouzouk I pushed my last commits. In total I used about the 5 hours extra I had for that.
I hope the changes are clear enough. Otherwise let me know, I can try to have a short look at it tomorrow.
You might need to change or add a few things. I didn't have the time to look at smaller details.
Each commit is for a different step page (3, 4, 5, 7), only step 7 has two commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants