Platform user handle fix #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosimameyer
requested review from
maelle,
drmowinckels and
a team
and removed request for
a team and
maelle
|
Building test-site now! The build will take a few minutes, but look at its progress in the website repo. |
|
I'm happy to leave it for mastodon, the pattern with the two @'s make a decent pattern for a regex and we have a solution for it, so that's fine. I just thought bluesky would be more like twitter etc, and then skipping the @ makes more sense. Great you managed to implement it so easily! |
drmowinckels
approved these changes
Dec 6, 2024
|
I'll leave the merging with you, just so you can make sure the bots and this are in sync :) |
|
Building test-site now! The build will take a few minutes, but look at its progress in the website repo. |
|
🎉 The preview is built! Check it out 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drmowinckels Referring to #135, I implemented some quick workaround for the Bluesky user handle in the bots and removed the
@signs (+ did some cleanup) with the existing blog entries. Do you also want to remove it for Mastodon? Let me know and I'll build something there as well (but I cannot promise to have it done by this week) 😊