-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] (feat) Seeding torch & rlberry #158
base: main
Are you sure you want to change the base?
Conversation
4118fe0
to
423f4bc
Compare
@mmcenta I merged your PR here to check that it all goes green (I will remove this commit before merging to main), it seems OK. I think we need to test it some more to see what is not going as planned. Mainly I changed the safe_reseed to include a reseed of torch seed. |
As indication: here is a little profiling of a call of an Agent Manager fitting a DQN environment :
syntax at the end is : description of action on seeder, filename and function of caller, and seed if this is a reseed. the profiling is done by adding some traceback utility in Seeder.py using the |
I was thinking about recording this metadata by using Python's |
Attempt of a fix for torch random generator compatibility.
In this PR I removed set_external_seed from agent_manager by tracking torch rng's state.
This PR would need some more testing. I put it out there for discussion's sake with issue #157 .