Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributes to A2C #358

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add attributes to A2C #358

wants to merge 5 commits into from

Conversation

riccardodv
Copy link
Collaborator

Added attributes to A2C, check for the future if it is better to eliminate redundancy with parameters.

@TimotheeMathieu
Copy link
Collaborator

I think it would be better to eliminate redundancy. If people want to get the parameters after instantiation, there is already get_params that is documented so they can use that without having to be said which parameters are set to attribute and which are not.

@KohlerHECTOR
Copy link
Collaborator

Good to mergne when duplicates are removed :).

@riccardodv
Copy link
Collaborator Author

I will do it soon, but I am on vacation these days, and I am travelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimotheeMathieu TimotheeMathieu Awaiting requested review from TimotheeMathieu

@KohlerHECTOR KohlerHECTOR Awaiting requested review from KohlerHECTOR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riccardodv @TimotheeMathieu @KohlerHECTOR