fix: don't create empty extra command files #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, removing fd and fdfind as we just need a simple directory listing. Keeping ripgrep because having one command that's consistent cross platform is nice.
rmagatti
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that it was creating empty extra command files after my changes due to an empty table vs nil mistake. Only place that uses the return is in
save_extra_cmds_newand it relies on the return being nil when there are no commands.Also made picker sort by modified as the default rather than leaving it up to whatever the underlying command decided it should sort by (or no sort at all). Having a consistent, reasonable default seems better.