Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements #92

Merged
merged 4 commits into from
Jan 17, 2025
Merged

General improvements #92

merged 4 commits into from
Jan 17, 2025

Conversation

manuelnaranjo
Copy link
Collaborator

NOTE: This is a replacement for #89, based on my company fork so I can push force and fix commits.

Changes:

  • allow to configure the log level (logrus) through an environmental variable, so we don't need to rebuild the binary each time.
  • allow to configure the rpm database cache path, this cache by default is stored relatively to the path where the binary gets called, but this means it can't be shared across multiple workspaces using bazeldnf and the same repos, and also that when multiple OSes are being used conflicts can arise (for instance when mixing centos7 and centos stream 9 while doing a migration). By making the path configurable and relative to XDG paths we can get some isolation. This cache is not used by bazel operations, but by bazeldnf binary when resolving dependency trees.
  • honor noarch repositories to avoid ending up with non fullfilled dependencies

@manuelnaranjo
go: allow to configure logrus level
ac0ea32 
Now the logrus level can be changed through the  environment variable
LOG_LEVEL
@manuelnaranjo
go: make cache dir configurable
f76520f 
Now the cache dir is global and can be configured properly, by default
it goes into XDG_CACHE_HOME/bazeldnf, this is useful when dealing with
multiple bazel repositories using bazeldnf.
@manuelnaranjo
bzlmod: expand ~ to $HOME
a42d575 
Replace ~ in paths with ${HOME} and then use golang functions to expand
env variables
@manuelnaranjo
Honor noarch in repos
ab77c57 
Some providers provide RPM repositories with an arch of noarch, where
they publish all the noarch packages they have. If we ignore these
repositories then we can't install the packages that depend on it
kellyma2
kellyma2 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@kellyma2 kellyma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manuelnaranjo manuelnaranjo merged commit 4eff8f0 into main Jan 17, 2025
13 checks passed
@manuelnaranjo manuelnaranjo deleted the mnaranjo/prepare-for-lock-file-2 branch January 17, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyma2 kellyma2 kellyma2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelnaranjo @kellyma2