Fix running multiple platform traces at once #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmosolgo
commented
Jul 5, 2023
| @platform_authorized_key_cache = Hash.new { |h, k| h[k] = platform_authorized_key(k) } | ||
| @platform_resolve_type_key_cache = Hash.new { |h, k| h[k] = platform_resolve_type_key(k) } | ||
|
|
||
| @platform_key_cache = Hash.new { |h, mod| h[mod] = mod::KeyCache.new } |
There was a problem hiding this comment.
The basic gist of the problem is here: since all the modules are mixed into a single class, they share a single set of instance variables and method definitions. I addressed this problem in two ways:
- Platform keys are now cached per-module, so each module can reference its own cached keys.
- Platform keys aren't fetched from the trace object itself; instead, the platform trace module is mixed into a new class, used only for getting those keys. That new class is assigned to
mod::KeyCache.
There was a problem hiding this comment.
That's jumping through a lot of hoops, but IIRC, OpenTelemetry uses PlatformTrace, and I'd like to not require any changes downstream -- I think this will be seamless 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4542