Develop #624
Merged
Develop #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal' and slightly modifying install.sh script
…t request, adding ENV variable to env example to ensure that lack of the variable doesn't break the app
Firecrawl use fetch
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -37,6 +40,12 @@ | |||
| const [deletingMap, setDeletingMap] = useState({}); | |||
| const [confirmClose, setConfirmClose] = useState(false); | |||
|
|
|||
| const goToDatasourcePage = (id: string) => { | |||
| if (isAirbyteEnabled) { | |||
| router.push(`/${resourceSlug}/datasource/${id}`); | |||
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 3 days ago
To fix the problem, we should avoid using user input directly in constructing the redirect URL. Instead, we can maintain a list of authorized redirects and choose from that list based on the user input. This ensures that only valid and safe URLs are used for redirection.
- Create a list of authorized
resourceSlugvalues. - Check if the
resourceSlugfromrouter.queryis in the list of authorized values. - Only perform the redirection if the
resourceSlugis authorized.
Suggested changeset
1
webapp/src/components/DatasourceTable.tsx
| @@ -42,5 +42,8 @@ | ||
|
|
||
| const authorizedResourceSlugs = ['validSlug1', 'validSlug2']; // Add all authorized slugs here | ||
| const goToDatasourcePage = (id: string) => { | ||
| if (isAirbyteEnabled) { | ||
| if (isAirbyteEnabled && authorizedResourceSlugs.includes(resourceSlug)) { | ||
| router.push(`/${resourceSlug}/datasource/${id}`); | ||
| } else { | ||
| toast.error('Unauthorized resource slug'); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 64d54c0 |
ragyabraham
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.