strip newlines from twitter embed #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this is the best way of handling it, but it worked for me. Background on this is that Jekyll was choking on the newline when a tweet was included as part of a list item, causing the list to close early and leaving a dangling `</div>` The Twitter embed comes back with `\n` between the blockquote and the script. For whatever reason Jekyll hated this. ¯\_(ツ)_/¯
|
Upon further testing, this is obviously not the correct way of fixing this. You'd additionally need to remove |
|
Yeah, I don't know correct way to fix this (not much of a developer anyhow, and certainly don't know much about the Ruby way). Feel free to close or update or whatever. |
|
No worries, I will try and get this fixed soon - suspect @blimey85 is correct here 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way of handling it, but it worked for me. Background on this is that Jekyll was choking on the newline when a tweet was included as part of a list item, causing the list to close early and leaving a dangling
</div>The Twitter embed comes back with
\nbetween the blockquote and the script. For whatever reason Jekyll hated this. ¯_(ツ)_/¯