Allow read method to accept multiple types for patient id #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `patient_id` param in `read` method renamed to `patient_identifier`
robberwick
force-pushed
the
pylibrelinkup-7-allow-read-method-to-accept-multiple-types-for-patient_id
branch
8 times, most recently
from
e7d13b2
to
e33ac3f
Compare
Use `python -m pytest` so that tests run correctly
robberwick
force-pushed
the
pylibrelinkup-7-allow-read-method-to-accept-multiple-types-for-patient_id
branch
from
e33ac3f
to
a22bfed
Compare
robberwick
deleted the
pylibrelinkup-7-allow-read-method-to-accept-multiple-types-for-patient_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the read method so that it can accept a
UUID,str, orPatientobject. This also introduce a breaking change, as thepatient_idparam ofreadis renamed topatient_identifier, to reduce confusion.closes: #7