Allow disable neutral root page

[Poil]

---

name: Pull request
about: Disable upload of neutral page and allow context

---

Describe the change
I propose this change to disable the management of the neutral page in case of you want to purge the default ROOT webapp and to allow a context (to map an app to the ROOT path by example)

Testing
I'm using it

[robertdebock]

Sounds like a good plan!

The build/test fails now, I think a modification is required. The error: (condensed)

'dict object' has no attribute 'neutral_default_page'
The error appears to be in '/github/workspace/robertdebock/ansible-role-tomcat/tasks/instance.yml': line 62

I think the condition should be changed a little. You now have:

  when:
    - instance.neutral_default_page

I guess you need to check if instance.neutral_default_page is defined too:

  when:
    - instance.neutral_default_page is defined
    - instance.neutral_default_page

Could you try that? Thank!

[Poil]

Hi,

Strange I configured a default to yes ... ?
I've added an is defined

[robertdebock]

Hm, now there is a check (in molecule/default/verify.yml that fails. The check sees if sensitive information is exposed.

• Please comment/remove the see if sensitive information is not exposed check from molecule/default/verify.yml.

I also see that instance.autodeploy was introduced but not tested nor described in defaults/main.yml.

• Please describe and set instance.autodeploy in defaults/main.yml. I'll generate the documentation (README.md) later.
• Please add a test in molecule/default/converge.yml:

      - name: "tomcat-autodeploy"
        shutdown_port: 8026
        non_ssl_connector_port: 8091
        ssl_connector_port: 8453
        ajp_port: 8200
        autodeploy: yes

Thanks!

[yodatak]

I'm interested in this functionality and news on this i can help if needed ?