Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for a nested extern module, get it working for all exce… #21

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add test case for a nested extern module, get it working for all exce… #21

wants to merge 7 commits into from

Commits on Oct 27, 2022

  1. Add test case for a nested extern module, get it working for all exce… 

    …pt Go
    @robin-aws
    robin-aws committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    ecc659a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Progress on Go

    @robin-aws
    robin-aws committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    023c7c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Working for Go! 

    * Fixed the fact that {:compile false} had no effect on modules
* Added Compiler.GetModuleCompileName so Go can further sanitize extern strings

Still not ideal because you have to explicitly attach {:compile false} to each intermediate extern module
    @robin-aws
    robin-aws committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    e8e4ace View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Cleanup

    @robin-aws
    robin-aws committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    6a8feed View commit details
    Browse the repository at this point in the history

  2. Comment

    @robin-aws
    robin-aws committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    35f47cb View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Fabio Madge <[email protected]>
    @robin-aws @fabiomadge
    robin-aws and fabiomadge authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    33d2468 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into github-issue-2045

    @robin-aws
    robin-aws authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8739a2b View commit details
    Browse the repository at this point in the history