Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy error for field_for_type function. Fixes #672 #673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

forsberg
Copy link

Description

An attempt to fix #672. I'm not all that experienced in using mypy/typing in Python, so there may be better ways.

#type: ignore is also an option, I guess.

@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #673 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          99       99           
  Lines       10193    10195    +2     
  Branches     1139     1139           
=======================================
+ Hits        10022    10024    +2     
  Misses        138      138           
  Partials       33       33           
Impacted Files Coverage Δ
faust/models/fields.py 97.26% <100.00%> (+<0.01%) ⬆️
faust/models/record.py 96.39% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b4c0a...12626a6. Read the comment docs.

@camerondavison
Copy link

any progress on getting this pushed through? it could be nice to get venusian upgraded

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Erik Forsberg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy version 0.790 complains on faust/models/records.py on master causing build failures
4 participants