Enhancements #6
Open
Enhancements #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if background loggers are created in several places, they are not sharing the message queue for one thread, so it cannot aggregate all logs for one thread. This can be solved by using Singleton instance of background logger.
The BackgroundMessage output is unexpected and not compatible with MainThread output, actually we can use Message in loggerhelper.py directly.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case 1: If background loggers are created in several places, they are not sharing the message queue for one thread, so it cannot aggregate all logs for one thread. This can be solved by using Singleton instance of background logger.
Use case 2: The 1st thread of BackgroundMessage output is unexpectedly printed in console and not compatible with MainThread output, actually we can use Message in loggerhelper.py directly.