Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced minimaze_ar.world with a new one containing AR markers that … #40

Open
wants to merge 2 commits into
base: melodic-devel
Choose a base branch
from

Conversation

evamotsh
Copy link
Contributor

…ar_track_alvar can detect. Added a launch file for the world. Added AR tag models used by the world.

…ar_track_alvar can detect. Added a launch file for the world. Added AR tag models used by the world.
@kruusamae kruusamae linked an issue Apr 29, 2021 that may be closed by this pull request
Copy link
Contributor

@kruusamae kruusamae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new README.md into the models folder to reference the tool/repp used for generating the models.

Comment on lines 3 to 20
<arg name="__ns" default=""/>
<arg name="world" default="$(find robotont_gazebo)/worlds/minimaze_ar.world" />
<arg name="x_pos" default="2"/>
<arg name="model" default="robotont_gazebo_nuc"/>
<env name="GAZEBO_MODEL_PATH" value="$(find robotont_gazebo)/models:$GAZEBO_MODEL_PATH" />
<include file="$(find gazebo_ros)/launch/empty_world.launch">
<arg name="world_name" value="$(arg world)"/>
</include>
<include file="$(find robotont_gazebo)/launch/upload_description.launch">
<arg name="__ns" value="$(arg __ns)"/>
<arg name="model" default="$(arg model)"/>
</include>
<!-- topic for 3d_mapping -->
<node if="$(eval model == 'robotont_gazebo_nuc')" name="relay" type="relay" pkg="topic_tools" args="camera/depth/image_rect_raw camera/aligned_depth_to_color/image_raw" />

<include file="$(find robotont_gazebo)/launch/spawn_urdf.launch" >
<arg name="x_pos" value="$(arg x_pos)" />
</include>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

launch-file seems overly complicated. try following the modular logic of ROS and our robotont packages. i can't think of any reason why this launch-file should not be copying the structure of world_minimaze.launch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ar tags in the gazebo world are not detected by ar_track_alvar
3 participants