make console command changes in respect to time backwards compatible #181
+88
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, an old client subscribed to a console, but then received generalized_time timestamps (instead of utc_time). now, this is cleaner: the old client will indicate that they need utc_time timestamp. discovered by @PizieDust
|
This breaks compatibility of stuff currently deployed (from the main branch), but I don't care enough about that. |
|
To be more precise, if you've deployed the latest release, everything is fine. If you have deployed the current main branch (since Mon Oct 2 10:58:45 2023 5d6e5c4), any 2.0.0 released versions won't interoperate (in respect to console). Now, after this change, again nothing will interoperate. Once you update to after this PR, suddenly 2.0.0 clients and future main branches will work again :) |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Aug 15, 2024
CHANGES: * BUGFIX install tls_endpoint as systemd service (not only as example), fix typo (robur-coop/albatross#183 @PizieDust) * BUGFIX albatross-influx: use "cow_faults" (fixed typo in robur-coop/albatross#182) as unsigned integer (b9695dd9c267f5e59f18154a632adba0481f9d72, @hannesm) * BUGFIX albatross-influx: avoid empty measurement (robur-coop/albatross#182 @hannesm) * BUGFIX tls-endpoint: don't fail if a bad client connects (robur-coop/albatross#180 @hannesm) * FEATURE tls-endpoint: add syslog support (esp. useful for inetd) (robur-coop/albatross#185 @hannesm) * FEATURE Update to FreeBSD 14 (robur-coop/albatross#172, @hannesm) * BUGFIX update command: make usable with local client (robur-coop/albatross#184, @reynir) * BUGFIX update command: handle HTTP not found explicitly (fixes robur-coop/albatross#147, robur-coop/albatross#171 @hannesm) * FEATURE Albatross: record start timestamp via info (fixes robur-coop/albatross#168, robur-coop/albatross#169 @hannesm) * BUGFIX Albatross: store timestamp as generalized time instead of utc time (robur-coop/albatross#167 @hannesm @reynir, adjusted by robur-coop/albatross#181 for backwards compatibility @PizieDust) * BUGFIX FreeBSD: restart services when they terminate (@hannesm, 64f28fbd88504ec33d6bfde5211684e0ba1bc193) * BUGFIX packaging: install albatross-client as albatross-client (@hannesm, 23acb8b3edbe0153e1bd24a1736b80e73a27e33f) * update nix inputs (robur-coop/albatross#175, robur-coop/albatross#179 @Julow) * use ohex instead of hex (robur-coop/albatross#174 @hannesm) * fix README (robur-coop/albatross#177 @PizieDust, 2a1c3d898b586946ce7c4f3171ea5eb856f4ade8, 107c235eb94e83d6a077c42ee8b527c207af4ba7)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: * BUGFIX install tls_endpoint as systemd service (not only as example), fix typo (robur-coop/albatross#183 @PizieDust) * BUGFIX albatross-influx: use "cow_faults" (fixed typo in robur-coop/albatross#182) as unsigned integer (b9695dd9c267f5e59f18154a632adba0481f9d72, @hannesm) * BUGFIX albatross-influx: avoid empty measurement (robur-coop/albatross#182 @hannesm) * BUGFIX tls-endpoint: don't fail if a bad client connects (robur-coop/albatross#180 @hannesm) * FEATURE tls-endpoint: add syslog support (esp. useful for inetd) (robur-coop/albatross#185 @hannesm) * FEATURE Update to FreeBSD 14 (robur-coop/albatross#172, @hannesm) * BUGFIX update command: make usable with local client (robur-coop/albatross#184, @reynir) * BUGFIX update command: handle HTTP not found explicitly (fixes robur-coop/albatross#147, robur-coop/albatross#171 @hannesm) * FEATURE Albatross: record start timestamp via info (fixes robur-coop/albatross#168, robur-coop/albatross#169 @hannesm) * BUGFIX Albatross: store timestamp as generalized time instead of utc time (robur-coop/albatross#167 @hannesm @reynir, adjusted by robur-coop/albatross#181 for backwards compatibility @PizieDust) * BUGFIX FreeBSD: restart services when they terminate (@hannesm, 64f28fbd88504ec33d6bfde5211684e0ba1bc193) * BUGFIX packaging: install albatross-client as albatross-client (@hannesm, 23acb8b3edbe0153e1bd24a1736b80e73a27e33f) * update nix inputs (robur-coop/albatross#175, robur-coop/albatross#179 @Julow) * use ohex instead of hex (robur-coop/albatross#174 @hannesm) * fix README (robur-coop/albatross#177 @PizieDust, 2a1c3d898b586946ce7c4f3171ea5eb856f4ade8, 107c235eb94e83d6a077c42ee8b527c207af4ba7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, an old client subscribed to a console, but then received generalized_time timestamps (instead of utc_time).
now, this is cleaner: the old client will indicate that they need utc_time timestamp.
discovered by @PizieDust