Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve load_config_once_with_permission documentation #376

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

planthaber
Copy link
Member

No description provided.

@planthaber planthaber requested a review from doudou July 13, 2022 14:35
@doudou
Copy link
Member

doudou commented Jul 15, 2022

hi @planthaber. CI does not pass because Rubocop changed a config name. Would you mind renaming the entry to make it pass ? That would be very helpful.

@planthaber planthaber changed the title Improve load_config_once_with_permission documentation Improve load_config_once_with_permission documentation Jul 15, 2022
@planthaber
Copy link
Member Author

I tried to fix the rubocop conifg, but wehn i follow the hint:

The Gemspec/DateAssignment cop has been removed. Please use Gemspec/DeprecatedAttributeAssignment instead.

I'm getting the next error:

Error: unrecognized cop or department Gemspec/DeprecatedAttributeAssignment found in .rubocop.yml
Did you mean Gemspec/OrderedDependencies?

For me it looks like there is no valid replacement, I removed it

Then, it complains about:

lib/autoproj/os_package_installer.rb:188:34: W: [Correctable] Lint/RedundantCopDisableDirective: Unnecessary disabling of Lint/EmptyWhen.

When I remove it:

lib/autoproj/os_package_installer.rb:188:17: W: Lint/EmptyWhen: Avoid when branches without a body.

So it is not just renaming ;-)

@planthaber
Copy link
Member Author

Now it seems to work:

Deleted the "Gemspec/DateAssignment" cop

and

Fixed "lib/autoproj/os_package_installer.rb:188" issue by calling "nil" (noop), based on https://stackoverflow.com/questions/13452624/equivalent-of-pass-in-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants