Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the last call to Gecode::Gist #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pierrewillenbrockdfki
Copy link
Collaborator

Gist is the Gecode Interactive Search Tool, using Qt to display a GUI.

This means the templ library depends on the qt version gecode is built with if Gecode::Gist is referenced anywhere, which poses a problem when it is to be used with a different qt version.

Gist is the Gecode Interactive Search Tool, using Qt to display a GUI.
@pierrewillenbrockdfki
Copy link
Collaborator Author

@2maz judging by the commented calls to Gecode::Gist, there seems to have been some effort to remove it already. Also, i cannot see how an interactive search tool would have a place in the non-gui library bits.

I am planning to remove Gecode::Gist and Gecode::Flatzinc from knowledge_reasoning/moreorg(where none of them is used either), so the reference here has to be removed first.

I'll be on vacation for a week and merge this afterwards if there are no problems/comments/it is not already merged.

@2maz
Copy link
Member

2maz commented Jul 20, 2023

Fine with me. Although I suggest to remove the reference then entirely. Not just commenting.

@pierrewillenbrockdfki
Copy link
Collaborator Author

Looks like the runs-on: ubuntu-18.04 has finally been removed. I'll do another PR that fixes that, merge that here and then things should be back to working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants