[WIP] Social network registration section #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove old tabs structure on settings#index - Add new partial '_settings_sections_list' to render all sections - Add locales for each section (:title and :description)
Every section will be rendered thought action settings#show. - Add routes - Add action :show
- Fix feature settings specs . - Add new feature settings specs for new show action.
Rename Keys: - 'feature.facebook_login' to 'social.facebook.login' - 'feature.twitter_login' to 'social.twitter.login' - 'feature.google_login' to to 'social.google.login'
…ings Update devise.rb initializer to load keys and secrets from Settings always if it's posible.
|
This PR is in WIP because I'd like @agileontheweb to check the responsive and styles. |
This was referenced Jul 29, 2019
|
Close via: #43 |
taitus
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Make hero full width * Fix repeating background for hero banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related Issues: #18 #19 #20
Objectives
Visual Changes
New index section:
Registration with social networks section:
Notes
The backward compatibility consists of trying to recover always the value of Settings, but in case it is empty we try to recover the value of the Secrets.