Consul portability #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
force-pushed
the
ciudades-abiertas/portability
branch
from
5aae01b to
458a22c
Compare
- Remove old tabs structure on settings#index - Add new partial '_settings_sections_list' to render all sections - Add locales for each section (:title and :description)
Every section will be rendered thought action settings#show. - Add routes - Add action :show
- Fix feature settings specs . - Add new feature settings specs for new show action. - Remove unnecessary specs
Rename Keys: - 'feature.facebook_login' to 'social.facebook.login' - 'feature.twitter_login' to 'social.twitter.login' - 'feature.google_login' to to 'social.google.login'
…ings Update devise.rb initializer to load keys and secrets from Settings always if it's posible.
* Added colspan="2" to have the same structure of the “update button” * Wrap featured_settings_form with the small-6 and column to have the same structure of the "update button" * Added small-6 and column on the span to have the same structure of the button “enabled/disabled” * Added style padding to the enabled and disabled class to center in the middle the text.
- Create settings related with secrets. - Add related locales titles and descriptions.
Use Retrocompatibility lib to load values from Settings always if it's posible. When Settings are blank, application will continue to use Secrets.
When update map values force redirect to same page, so as not to lose the page we are updating.
- Add English translate
- I've taken away the wizard because I don't think it's any use
Fix jump effect "no button in the header" from step 1 to step 2
Update sms api to load 'sms api' values from Settings always if it's posible.
Render all settings related with "SMS configuration"
Add task to copy sms configuration from secrets to Settings.
taitus
force-pushed
the
ciudades-abiertas/portability
branch
from
1d44c0e to
bc418a8
Compare
taitus
force-pushed
the
master
branch
2 times, most recently
from
25ba35f to
df9b00f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related Issues: #18
Objectives
Group all PR related with related issue #18
Notes
Advanced Configuration
rake settings:copy_http_basic_auth_to_settingsSMTP Configuration
Case 1:
For existing installations that have the email smtp configuration correctly updated in the symbolic link(for example shared/config/environments/production.rb) it will be necessary to execute the following rake task for the sending of emails to continue working correctly.
This rake task copies the SMTP configuration of your server to the new Settings that the application needs in order to load the email configuration correctly.
Please execute next command
rake settings:update_smtp_settingsRemember that until you execute the rake task the sending of emails will be disabled.
You can validate that the rake task has been executed correctly by accessing the administration panel in the Settings > SMTP configuration section and seeing that all the fields are correctly filled in.
Case 2:
If your existing installation use default ActionMailer::Base.delivery_method and default ActionMailer::Base.smtp_settings and you manage internally the sending of emails
with redirections or another stuff, you must not execute the rake task.
When this feature is disabled the sending of emails keep behaving in the same way.
SMS Configuration
The backward compatibility consists of trying to recover always the value of Settings, but in case it is empty we try to recover the value of the Secrets.
rake settings:copy_sms_configuration_to_settings