[EXPERIMENTAL] Allow to render translations fields separately #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to render the translations fields separated from each other, with not translatable fields or any other HTML component in between. Unfortunately, this was not possible because the hidden fields
:_destroy
and:locale
were rendered for eachtranslatable_field
call resulting in duplicated fields for each translation and invalid HTML. So now we ensure to render each translation hidden_fields once per form.In addition, the form fields for the same translation had a different index when using more than one
translatable_fields
block. So now, the index we use for translation fields is the position the translation locale occupies in the application's array of available languages.This is an example of what we want to do:
The output for the previous code before this patch was:
Now, translation hidden fields are not duplicated and the index is the same for the same translation fields: