Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r-packages] allow whitespace in packages #207

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

dpprdan
Copy link
Contributor

@dpprdan dpprdan commented Nov 16, 2023

This is a small change to allow for whitespace in the packages specification, so that using

"packages": "cli, rlang"

does not lead to an error.

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Could you add a new test case and bump the minor version?

@dpprdan
Copy link
Contributor Author

dpprdan commented Nov 16, 2023

@eitsupi Is the test correct like this? I am not sure.

I'll add a similar test for the apt-packages feature. It would only be consistent if it also allowed for whitespace in the package list. It already does IIUC, but a test might be useful to prevent a regression? Feel free to revert, if this doesn't make sense.

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eitsupi eitsupi merged commit f9e426d into rocker-org:main Nov 16, 2023
18 checks passed
@dpprdan dpprdan deleted the feat/r_packages_allow_whitespace branch November 17, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants