-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(r-apt): Added case-sensitivity of apt packages warning #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
However, I think it is too topical to mention r-cran-* here (i.e., I believe that this Feature is used more often for purposes other than R package installation).
How about adding to the following section?
devcontainer-features/src/r-apt/README.md
Lines 65 to 82 in 95fb05b
If you want to install R packages via apt during the container build phase, | |
you can use [the `ghcr.io/rocker-org/devcontainer-features/apt-packages` Feature](https://github.com/rocker-org/devcontainer-features/blob/main/src/apt-packages) | |
to do so. | |
```json | |
"features": { | |
"ghcr.io/rocker-org/devcontainer-features/r-apt:latest": {}, | |
"ghcr.io/rocker-org/devcontainer-features/apt-packages:1": { | |
"packages": "r-cran-curl" | |
} | |
}, | |
"overrideFeatureInstallOrder": [ | |
"ghcr.io/rocker-org/devcontainer-features/r-apt" | |
] | |
``` | |
`ghcr.io/rocker-org/devcontainer-features/apt-packages` is not guaranteed to install after this Feature, | |
so be sure to set up [the `overrideFeatureInstallOrder` property](https://containers.dev/implementors/features/#overrideFeatureInstallOrder). |
And, it seems that uppercase letters cannot be used in apt package names in the first place.
https://askubuntu.com/questions/1262528/what-are-usable-characters-are-for-package-names
Thank you so much for your kind response! Embarassingly, I had overlooked the I'd be happy to add to the section you referenced, and perhaps add an additional comment to simply point out that the Would you prefer that I make these changes to the NOTES.md file or the README.md? |
Thanks for checking this out. Yes, you are correct, the README is automatically generated from the NOTES, so we need to edit the NOTES. |
I moved the anecdote & example from the Please let me know if this is what you had in mind, or if there are any additional changes I should make. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The README has been updated by b24eea2. |
Considering R users who may used to installing R packages via
install.packages(...)
(where package names may be a mix of upper- and lower-case letters) from an R session, I believe it may be useful to document that installing R packages viaapt-packages
requires that the package name be lowercase withinr-cran-<package>
.