Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add offline mode #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brad-u410
Copy link

@brad-u410 brad-u410 commented May 16, 2023

This enables operators to still run the API and Node containers, making it easier to keep the node operator key entirely offline.

I'm currently testing this for internal use, but wanted to see if this was worth getting merged upstream.

brad-u410 and others added 2 commits May 16, 2023 12:33
This enables operators to still run the API and Node containers,
making it easier to keep the node operator key entirely offline.
@jclapis
Copy link
Member

jclapis commented May 17, 2023

This is actually going to be useful for an upcoming refactor we have planned. Offline is kind-of a misnomer if what it really means is "simulate all of the transactions but don't actually sign and submit anything to the network"; if I were to merge this upstream I'd probably replace the name with something like "simulation mode".

@brad-u410
Copy link
Author

@jclapis - in my case, the node operator key is kept offline. When it needs to sign transactions, those are transferred to the airgapped machine, signed, exported and broadcast.

However, that caused two issues:

  1. Most the of CLI no longer works, even for informational commands
  2. I don't know what transactions I would have been automatically signing via the smartnode container, as I can't run that service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants